feat(textarea,data-grid): interactive elements and controlled height #4291
+195
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: a3fd875 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:L
github-actions
bot
added
Area: Components
|
View your CI Pipeline Execution ↗ for commit a3fd875.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 90d3da5.
☁️ Nx Cloud last updated this comment at |
krisantrobus
commented
Mar 31, 2025
Comment on lines
+2
to
+3
| "@twilio-paste/data-grid": patch | ||
| "@twilio-paste/core": patch |
There was a problem hiding this comment.
I did a patch because no API change for consumers just internal functions
|
Size Change: -18 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3fd875:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-data-grid-focus
|
| Run status |
|
| Run duration | 04m 14s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
roxanagomez
previously approved these changes
Mar 31, 2025
github-actions
bot
added
Type: Documentation
krisantrobus
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
PixeledCode
previously approved these changes
Apr 1, 2025
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix-data-grid-focus
|
| Run status |
|
| Run duration | 07m 36s |
| Commit |
|
| Committer | krisantrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
nkrantz
previously approved these changes
Apr 1, 2025
roxanagomez
approved these changes
Apr 2, 2025
nkrantz
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataGrid Component Updates:
ensureFocusfunction and thehandleMouseDownevent handler fromDataGridCellto improve focus handling for interactive elements (packages/paste-core/components/data-grid/src/DataGridCell.tsx). [1] [2]FixedCellHeightDataGridcomponent (packages/paste-core/components/data-grid/stories/index.stories.tsx).TextArea Component Enhancements:
minRowsprop to theTextAreacomponent, allowing the configuration of the minimum height of the textarea (packages/paste-core/components/textarea/src/TextArea.tsx). [1] [2] [3]